Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile with multiple activations should be processed only once. #5182

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Profile with multiple activations should be processed only once. #5182

merged 1 commit into from
Dec 23, 2020

Conversation

gsquared94
Copy link
Contributor

Fixes: #5179

@gsquared94 gsquared94 requested a review from a team as a code owner December 23, 2020 01:24
@google-cla google-cla bot added the cla: yes label Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020 •
edited
Loading

Codecov Report

Merging #5182 (fb77322) into master (056bc1d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5182      +/-   ##
==========================================
+ Coverage   72.39%   72.43%   +0.03%     
==========================================
  Files         385      385              
  Lines       13735    13736       +1     
==========================================
+ Hits         9944     9949       +5     
+ Misses       3063     3061       -2     
+ Partials      728      726       -2
Impacted Files Coverage Δ
pkg/skaffold/schema/profiles.go 89.47% <100.00%> (+0.06%) ⬆️
pkg/skaffold/util/tar.go 56.00% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 056bc1d...fb77322. Read the comment docs.

MarlonGamez
MarlonGamez approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁

@gsquared94 gsquared94 merged commit a518ce7 into GoogleContainerTools:master Dec 23, 2020
IsaacPD pushed a commit to IsaacPD/skaffold that referenced this pull request Dec 23, 2020
@gsquared94 @IsaacPD
Profile with multiple activations should be processed only once. (Goo…
15d800f 
…gleContainerTools#5182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarlonGamez MarlonGamez MarlonGamez approved these changes

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiles with two activation criteria can cause patches to run twice
2 participants
@gsquared94 @MarlonGamez